Update CreateMigration time to UTC #38
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The timestamp used on files when using `create` should be in UTC. Developers may be distributed across timezones and so the time should be standardized and not rely on local time.
VojtechVitek
reviewed
May 5, 2017
There was a problem hiding this comment.
Actually, we might drop the timestamps in favor of incrementing the version numbers. See #27
|
After reading #25, it looks like the proposed sequential creation of migration files is optional only, correct? |
|
@duffn yea, I think so. It's just what filename would "create" command choose by default. The comparison logic would stay the same. |
|
Cool. Then I think this PR is still valid then. |
|
Superseded by #50. Thanks for your contribution! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The timestamp used on files when using
createshould be in UTC.Developers may be distributed across timezones and so the time
should be standardized and not rely on local time.