Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Henry/so 809 valueerror signal #28

Closed
wants to merge 2 commits into from

Conversation

henryyeh
Copy link

SUMMARY

BEFORE/AFTER SCREENSHOTS OR ANIMATED GIF

TEST PLAN

ADDITIONAL INFORMATION

  • Has associated issue:
  • Changes UI
  • Requires DB Migration.
  • Confirm DB Migration upgrade and downgrade tested.
  • Introduces new feature or API
  • Removes existing feature or API

@codecov-commenter
Copy link

codecov-commenter commented Aug 25, 2020

Codecov Report

Merging #28 into master will increase coverage by 0.14%.
The diff coverage is 100.00%.

Impacted file tree graph

@@            Coverage Diff             @@
##           master      #28      +/-   ##
==========================================
+ Coverage   64.26%   64.40%   +0.14%     
==========================================
  Files         785      785              
  Lines       36981    36983       +2     
  Branches     3530     3513      -17     
==========================================
+ Hits        23764    23818      +54     
+ Misses      13110    13058      -52     
  Partials      107      107              
Flag Coverage Δ
#cypress 54.83% <ø> (-0.07%) ⬇️
#javascript 60.91% <ø> (ø)
#python 59.77% <100.00%> (+0.24%) ⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

Impacted Files Coverage Δ
superset/utils/core.py 89.47% <100.00%> (+0.03%) ⬆️
...rontend/src/SqlLab/components/QueryAutoRefresh.jsx 65.90% <0.00%> (-6.82%) ⬇️
superset-frontend/src/SqlLab/actions/sqlLab.js 65.17% <0.00%> (ø)
superset/connectors/sqla/models.py 89.72% <0.00%> (+0.13%) ⬆️
superset/models/core.py 87.50% <0.00%> (+0.27%) ⬆️
superset/views/database/mixins.py 82.45% <0.00%> (+1.75%) ⬆️
superset/examples/birth_names.py 100.00% <0.00%> (+2.63%) ⬆️
superset/examples/world_bank.py 100.00% <0.00%> (+2.89%) ⬆️
superset/db_engine_specs/presto.py 81.65% <0.00%> (+10.73%) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 4b40d44...7d4b2b5. Read the comment docs.

@henryyeh henryyeh closed this Aug 26, 2020
@henryyeh henryyeh deleted the henry/SO-809-valueerror-signal branch August 27, 2020 20:46
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants