-
Notifications
You must be signed in to change notification settings - Fork 11
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat(SqlLab): Change Save Dataset Button to Split Save Query Button III #234
Conversation
> columns are loading into page
…ype is Query [41493] Initial commit to add ability for the a Query Preview Modal to be available when the data source type is Query and not Dataset Converted ModalTrigger to a functional TypeScript component
> allow for all records to be displayed > fix select with all columns queries > filters are now working
…hart-power-query
…pes from DatasourceTypes options
…/query-preview-modal-for-chart-source-query
…hart-power-query
…view-modal-for-chart-source-query feat: Ericbriscoe/sc 41493/query preview modal for chart source query
… SqlLab and Explore
…set, adds default metric when chart source is query
… datasource A follow on separate effort will enable having a default Count metric when Query is the datasource type
fix: Move chart samples to explore resource endpoint
Codecov Report
@@ Coverage Diff @@
## chart-power-query #234 +/- ##
=====================================================
+ Coverage 66.35% 66.39% +0.03%
=====================================================
Files 1757 1758 +1
Lines 66624 66629 +5
Branches 7045 7046 +1
=====================================================
+ Hits 44211 44238 +27
+ Misses 20614 20598 -16
+ Partials 1799 1793 -6
Flags with carried forward coverage won't be shown. Click here to find out more.
Continue to review full report at Codecov.
|
2a57a4f
to
555d26b
Compare
Continued in this PR: apache#20852 |
SUMMARY
This changes the current save query button into a split save button if the database has "Allow this database to be explored" enabled. When the user clicks the caret section of the button, they can now save the query as a dataset.
Bonus
: In order to create this button, I conveniently needed to fix the styling on the "Run" query split button. The split line now goes all the way through the button and the caret is centered.BEFORE/AFTER SCREENSHOTS OR ANIMATED GIF
BEFORE:
AFTER:
TESTING INSTRUCTIONS
v
section of the button, then click "Save dataset" to see the save dataset modalADDITIONAL INFORMATION