fix(dbt Cloud): Allow None on custom_branch_only field and update some endpoints to v3 #330
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
betodealmeida
approved these changes
Dec 16, 2024
| @@ -724,7 +724,7 @@ def get_accounts(self) -> List[AccountSchema]: | |||
| """ | |||
| List all accounts. | |||
| """ | |||
| url = self.baseurl / "api/v2/accounts/" | |||
| url = self.baseurl / "api/v3/accounts/" | |||
There was a problem hiding this comment.
Maybe we could define somewhere:
V2_API = self.baseurl / "api/v2"
V3_API = self.baseurl / "api/v3"Then here we could:
url = V3_API / "accounts/"There was a problem hiding this comment.
ohh, that's a good idea! I have to do a follow up on other dbt Cloud related issue and I can include this.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
When loading information about jobs from a dbt Cloud project, it's possible that the
custom_branch_onlyfield (from theTriggerSchema) returnsNone. This PR adds supports for such scenario.It also updates some endpoints to use dbt Cloud v3 API.