fix(dbt): Removing BQ-specific metadata from columns (#278)

preset-io · Apr 10, 2024 · d5285ca · d5285ca
1 parent b7bd31a
commit d5285ca
Show file tree

Hide file tree

Showing 2 changed files with 6 additions and 0 deletions.
diff --git a/src/preset_cli/cli/superset/sync/dbt/datasets.py b/src/preset_cli/cli/superset/sync/dbt/datasets.py
@@ -46,6 +46,9 @@ def clean_metadata(metadata: Dict[str, Any]) -> Dict[str, Any]:
         "name",
         "nullable",
         "type_generic",
+        "precision",
+        "scale",
+        "max_length",
     ):
         if key in metadata:
             del metadata[key]

diff --git a/tests/cli/superset/sync/dbt/datasets_test.py b/tests/cli/superset/sync/dbt/datasets_test.py
@@ -1391,6 +1391,9 @@ def test_clean_metadata() -> None:
         "nullable": "Nullable",
         "type_generic": "Type Generic",
         "yeah": "sure",
+        "precision": "very precise",
+        "scale": "to the max",
+        "max_length": 9000,
     }
     result = clean_metadata(test_data)
     assert result == {