Fixing test coverage

preset-io · Apr 5, 2024 · 9fe3177 · 9fe3177
1 parent 86fae26
commit 9fe3177
Showing 1 changed file with 4 additions and 4 deletions.
diff --git a/src/preset_cli/cli/superset/sync/dbt/metrics.py b/src/preset_cli/cli/superset/sync/dbt/metrics.py
@@ -93,11 +93,11 @@ def get_metric_expression(metric_name: str, metrics: Dict[str, MetricSchema]) ->
             expression = sqlglot.parse_one(sql, dialect=metric["dialect"])
         except ParseError:
             for parent_metric in metric["depends_on"]:
-                metric_name = parent_metric.split(".")[-1]
-                pattern = r"\b" + re.escape(metric_name) + r"\b"
-                parent_metric_syntax = get_metric_expression(metric_name, metrics)
+                parent_metric_name = parent_metric.split(".")[-1]
+                pattern = r"\b" + re.escape(parent_metric_name) + r"\b"
+                parent_metric_syntax = get_metric_expression(parent_metric_name, metrics)
                 sql = re.sub(pattern, parent_metric_syntax, sql)
-                return sql
+            return sql
 
         tokens = expression.find_all(exp.Column)