Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add two more disqualifications for isCascadable(). #914

Merged
merged 2 commits into from
Nov 20, 2018
Merged

Add two more disqualifications for isCascadable(). #914

Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
5430ef0
Add two more disqualifications for isCascadable().
PhilRunninger Nov 8, 2018
82289b9
Add comments to explain the new exclusions for bookmarks and symlinks.
Nov 12, 2018
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
16 changes: 15 additions & 1 deletion lib/nerdtree/tree_dir_node.vim
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -370,12 +370,26 @@ function! s:TreeDirNode.hasVisibleChildren()
endfunction

" FUNCTION: TreeDirNode.isCascadable() {{{1
" true if this dir has only one visible child - which is also a dir
" true if this dir has only one visible child that is also a dir
" false if this dir is bookmarked or symlinked. Why? Two reasons:
" 1. If cascaded, we don't know which dir is bookmarked or is a symlink.
" 2. If the parent is a symlink or is bookmarked, you end up with unparsable
" text, and NERDTree cannot get the path of any child node.
function! s:TreeDirNode.isCascadable()
if g:NERDTreeCascadeSingleChildDir == 0
return 0
endif

if self.path.isSymLink
return 0
endif

for i in g:NERDTreeBookmark.Bookmarks()
if i.path.equals(self.path)
return 0
endif
endfor

let c = self.getVisibleChildren()
return len(c) == 1 && c[0].path.isDirectory
endfunction
Expand Down