Decrease startup-time by avoiding linear-time iteration over key mappings #851
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This commit makes adding, removing and finding key maps an O(1) operation instead of O(n), where n is the number of pre-existing maps. In my testing, averaged over 100 iterations, this reduces the time spent initializing NERDTree at Vim startup from ~73ms to ~9.7ms. That's with only the default included key maps.
|
I think this fixes the majority of the startup time issue #276 |
mnussbaum
changed the title
PhilRunninger
approved these changes
Jun 11, 2018
lifecrisis
requested changes
Jun 12, 2018
|
Thanks! Just pushed 657be6b to update the private function to add the leading underscore |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This commit makes adding, removing and finding key maps an O(1) operation instead of O(n), where n is the number of pre-existing key mappings.
In my testing, averaged over 100 iterations, this reduces the time spent initializing NERDTree at Vim startup from ~73ms to ~9.7ms. That's with only the default included key maps. I've also confirmed that adding more key mappings doesn't meaningfully increase NERDTree startup time with this patch, and that it does without it.
I chose to add an internal
s:KeyMap.allfunction to initialize and return the key map dictionary so that the publics:KeyMap.Allfunction's signature stays the same, returning a sorted list of key maps.Let me know if there're any revisions you'd like to see!