Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: CLI for page router, locale in page router props #453

Merged
merged 2 commits into from
Oct 2, 2024

Conversation

foyarash
Copy link
Collaborator

@foyarash foyarash commented Oct 2, 2024

Title

Fixes some issues with page router both with the CLI and the lib

Type of Change

  • New feature
  • Bug fix
  • Documentation update
  • Example update
  • Refactoring
  • Hotfix
  • Security patch
  • UI/UX improvement

Issue

#452

Description

This PR fixes some issues with the Page Router :

  • on the library side, we were not passing the locale prop to getNextAdminProps
  • on the CLI side, we were generating content with syntax errors and an invalid CSS import. We also needed to add instructions about SuperJson configuration.

@foyarash foyarash requested a review from cregourd October 2, 2024 09:54
Copy link

changeset-bot bot commented Oct 2, 2024

🦋 Changeset detected

Latest commit: 9963a18

The changes in this PR will be included in the next version bump.

This PR includes changesets to release 2 packages
Name Type
@premieroctet/next-admin Patch
@premieroctet/next-admin-cli Patch

Not sure what this means? Click here to learn what changesets are.

Click here if you're a maintainer who wants to add another changeset to this PR

@foyarash foyarash merged commit 62436a5 into main Oct 2, 2024
3 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants