Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

gmake2: Fix detecting msdos vs posix shell #2039

Merged
merged 1 commit into from
Apr 11, 2023
Merged

gmake2: Fix detecting msdos vs posix shell #2039

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
12 changes: 11 additions & 1 deletion modules/gmake2/gmake2.lua
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -259,8 +259,18 @@


function gmake2.shellType()
-- Determine whether the build rules
-- of the Makefile are being executed under
-- cmd.exe or sh.exe. GNU Make prefers using
-- `sh.exe`, if it is found on the PATH (see variable.c).
-- Therefore, the shell make is being executed from,
-- and the shell used to execute the build rules can be different
--
-- To determine this, use a "polyglot test" by executing
-- echo "test" in the shell. cmd.exe will write "test" with quotes
-- and sh will write test without quotes.
_p('SHELLTYPE := posix')
_p('ifeq (.exe,$(findstring .exe,$(ComSpec)))')
_p('ifeq ($(shell echo \"test\"), \"test\")')
_p('\tSHELLTYPE := msdos')
_p('endif')
_p('')
Expand Down