Add configuration condition to VS csproj references ItemGroup #1723
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What does this PR do?
Consider the following
premake5.lua
script line:If you have more than one optimizations it will only consider the first one found. So, for example, if you have
Debug
andRelease
optimizations, the only DLL linked will be theDebug
one, resulting in the following VS csproj configuration:The changes in this PR make it possible to apply the same condition used in the
<PropertyGroup>
to the<ItemGroup>
when linking a DLL in a VS csproj, resulting in the following VS csproj configuration (considering the previous example).How does this PR change Premake's behavior?
After this PR, any VS csproj that links a DLL will have the condition applied for each optimization defined. For example, if only
Debug
is used, the VS csproj will change from this:To this:
Anything else we should know?
Not really, the changes are pretty straight forward.
Did you check all the boxes?
closes #XXXX
in comment to auto-close issue when PR is merged)You can now support Premake on our OpenCollective. Your contributions help us spend more time responding to requests like these!