Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[pull] master from iluwatar:master #123

Merged
merged 3 commits into from
Jan 12, 2025
Merged

[pull] master from iluwatar:master #123

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
3 commits
Select commit Hold shift + click to select a range
fee3c43
fix: Update presubmit action
iluwatar Jan 12, 2025
03f0bee
doc: Update PR template
iluwatar Jan 12, 2025
f0f4c7d
build(deps): bump com.fasterxml.jackson.core:jackson-core (#3171)
dependabot[bot] Jan 12, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
14 changes: 11 additions & 3 deletions .github/workflows/presubmit.yml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -6,8 +6,9 @@ permissions:
issues: write

on:
pull_request:
pull_request_review_comment:
pull_request_target: # Handle forked repository PRs in the base repository context
types: [opened, synchronize]
pull_request_review_comment: # Handle review comments
types: [created]

jobs:
Expand All @@ -20,7 +21,14 @@ jobs:
echo "Error: LLM_API_KEY secret is not configured"
exit 1
fi
- uses: presubmit/ai-reviewer@latest

- name: Check out PR code
uses: actions/checkout@v3
with:
ref: ${{ github.event.pull_request.head.sha }}

- name: Run AI Reviewer
uses: presubmit/ai-reviewer@latest
env:
GITHUB_TOKEN: ${{ secrets.GITHUB_TOKEN }}
LLM_API_KEY: ${{ secrets.LLM_API_KEY }}
Expand Down
15 changes: 4 additions & 11 deletions PULL_REQUEST_TEMPLATE.md
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,14 +1,7 @@
<!--
Thank you for contributing to Java Design Patterns!
# Pull Request Template

If you're unsure where to start, please refer to the contributing doc:
## What does this PR do?

https://github.com/iluwatar/java-design-patterns/wiki/01.-How-to-contribute
<!-- Provide a short description of what this pull request does. -->

If you still have questions, please let us know via issues or [gitter](https://matrix.to/#/#iluwatar_java-design-patterns:gitter.im).
-->

## What problem does this PR solve?

<!-- Please describe the problem you're trying to solve. Uncomment the following line if this PR closes some issues -->
<!-- Close #<issue number> -->
<!-- Fixes #<issue-number> (if applicable) -->
2 changes: 1 addition & 1 deletion dynamic-proxy/pom.xml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -38,7 +38,7 @@
<dependency>
<groupId>com.fasterxml.jackson.core</groupId>
<artifactId>jackson-core</artifactId>
<version>2.18.1</version>
<version>2.18.2</version>
</dependency>
<dependency>
<groupId>com.fasterxml.jackson.core</groupId>
Expand Down
2 changes: 1 addition & 1 deletion event-sourcing/pom.xml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -42,7 +42,7 @@
<dependency>
<groupId>com.fasterxml.jackson.core</groupId>
<artifactId>jackson-core</artifactId>
<version>2.18.1</version>
<version>2.18.2</version>
</dependency>
<dependency>
<groupId>com.fasterxml.jackson.core</groupId>
Expand Down
Loading