Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove bad check #683

Merged
merged 2 commits into from
Nov 15, 2024
Merged

Remove bad check #683

merged 2 commits into from
Nov 15, 2024

Conversation

magdyksaleh
Copy link
Collaborator

Some small models have shared layer for LM head and embedding. SO this check wasn't working as needed and we are OK without it.

@magdyksaleh magdyksaleh merged commit e4394d6 into main Nov 15, 2024
1 check passed
@magdyksaleh magdyksaleh deleted the fix-support-for-small-merged-models branch November 15, 2024 19:48
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants