Add --disable-sgmv flag #639
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
tgaddair
reviewed
Oct 15, 2024
tgaddair
reviewed
Oct 15, 2024
|
@tgaddair getting a bunch of GPG errors when trying to fetch some nvidia stuff, any idea what's up with that? Doesn't seem remotely related to my PR. (Build log here: https://github.com/predibase/lorax/actions/runs/11338623040/job/31532139387?pr=639) This is a pretty trivial PR but would be nice to test it... |
|
I think the issue is with the builder instance running out of space. I'll take a look and see if I can clean it up. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Adds --disable-sgmv, which sets
DISABLE_SGMV=1.Tested by spinning up a deployment with this build and using debug code to verify that the env var is seen by the lorax server.