Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

add missed dtypes for 8bit kv cache #490

Merged
merged 5 commits into from
May 28, 2024
Merged

add missed dtypes for 8bit kv cache #490

merged 5 commits into from
May 28, 2024

Conversation

flozi00
Copy link
Collaborator

@flozi00 flozi00 commented May 27, 2024

What does this PR do?

Fixes # (issue)

Before submitting

  • This PR fixes a typo or improves the docs (you can dismiss the other checks if that's the case).
  • Was this discussed/approved via a Github issue or the discord / slack channel? Please add a link
    to it if that's the case.
  • Did you write any new necessary tests?

Who can review?

Anyone in the community is free to review the PR once the tests have passed. Feel free to tag
members/contributors who may be interested in your PR.

@flozi00 flozi00 requested a review from tgaddair May 27, 2024 18:28
@flozi00
Copy link
Collaborator Author

flozi00 commented May 27, 2024

Forgot to undo the build yaml, sorry
Feel free to take this pr

@tgaddair tgaddair merged commit 7d6b1d4 into main May 28, 2024
1 check passed
@tgaddair tgaddair deleted the quant_cache branch May 28, 2024 21:13
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@tgaddair tgaddair Awaiting requested review from tgaddair

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@flozi00 @tgaddair