Fix top_p to allow setting it to 1.0 (#676)

predibase · Nov 12, 2024 · 9082d36 · 9082d36
1 parent 8f2cbf7
commit 9082d36
Showing 1 changed file with 2 additions and 2 deletions.
diff --git a/router/src/validation.rs b/router/src/validation.rs
@@ -277,7 +277,7 @@ impl Validation {
         // for the user
         let top_p = top_p
             .map(|value| {
-                if value <= 0.0 || value >= 1.0 {
+                if value <= 0.0 || value > 1.0 {
                     return Err(ValidationError::TopP);
                 }
                 Ok(value)
@@ -884,7 +884,7 @@ mod tests {
                 GenerateRequest {
                     inputs: "Hello".to_string(),
                     parameters: GenerateParameters {
-                        top_p: Some(1.0),
+                        top_p: Some(1.1),
                         ..default_parameters()
                     },
                     add_special_tokens: true,