-
-
Notifications
You must be signed in to change notification settings - Fork 115
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
flow-over-heated-plate: Remove unnecessary parameter #234
Conversation
I also removed |
Have you also tried this with different OpenFOAM versions? I can imagine that this was there for technical reasons, even if not used. But most probably this originates from the very first prototypes, which were probably also based on something else (as is common in OpenFOAM). |
Of course, not 😏 |
@BenjaminRodenberg Don't forget the changelog entry. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Indeed. From the OpenFOAM 8 docs:
nMoles: number of moles of component. This entry is only used for combustion modelling based on regress variable with a homogeneous mixture of reactants; otherwise it is set to 1.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This looks correct. From the OpenFOAM.org user guide:
nMoles: number of moles of component. This entry is only used for combustion modelling based on regress variable with a homogeneous mixture of reactants; otherwise it is set to 1.
See #226 (comment): From my current perspective, we do not need
nMoles
.