Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

flow-over-heated-plate: Remove unnecessary parameter #234

Merged
merged 4 commits into from
Feb 1, 2022

Conversation

BenjaminRodenberg
Copy link
Member

See #226 (comment): From my current perspective, we do not need nMoles.

@BenjaminRodenberg
Copy link
Member Author

I also removed nMoles in the cases flow-over-heated-plate-steady-state and flow-over-heated-plate-nearest-projection, but did not check any results.

@BenjaminRodenberg BenjaminRodenberg added this to the v202104.2.0 milestone Aug 11, 2021
@BenjaminRodenberg BenjaminRodenberg changed the title flow-over-hot-plate: Remove unnecessary parameter flow-over-heated-plate: Remove unnecessary parameter Aug 11, 2021
@MakisH
Copy link
Member

MakisH commented Aug 12, 2021

Have you also tried this with different OpenFOAM versions? I can imagine that this was there for technical reasons, even if not used. But most probably this originates from the very first prototypes, which were probably also based on something else (as is common in OpenFOAM).

@BenjaminRodenberg
Copy link
Member Author

Have you also tried this with different OpenFOAM versions?

Of course, not 😏

@uekerman
Copy link
Member

@BenjaminRodenberg Don't forget the changelog entry.

Copy link
Member

@MakisH MakisH left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Indeed. From the OpenFOAM 8 docs:

nMoles: number of moles of component. This entry is only used for combustion modelling based on regress variable with a homogeneous mixture of reactants; otherwise it is set to 1.

Copy link
Member

@MakisH MakisH left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This looks correct. From the OpenFOAM.org user guide:

nMoles: number of moles of component. This entry is only used for combustion modelling based on regress variable with a homogeneous mixture of reactants; otherwise it is set to 1.

@MakisH MakisH merged commit e472814 into develop Feb 1, 2022
@MakisH MakisH deleted the BenjaminRodenberg-remove-nMoles branch February 1, 2022 22:34
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
No open projects
Development

Successfully merging this pull request may close these issues.

3 participants