-
-
Notifications
You must be signed in to change notification settings - Fork 112
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Adding a change log #225
Adding a change log #225
Conversation
Looks good: it looks like you followed the format used in preCICE and you transferred the release notes (have not checked in detail). Just remember to contribute the changelog entries as independent files, to avoid merge conflicts. |
I dont really understand what you are saying here, can you please explain more 😅 |
Have a look at the preCICE changelogs: https://github.com/precice/precice/tree/develop/docs/changelog The |
Okay, so this would only be valid for changes done from the last release till now correct? And how do we decide the numbers in the names of the files? Would the merge conflicts happen because multiple feature developments would consecutively edit the CHANGELOG? In that case does it not work if every feature developer just pulls, resolves the conflict and pushes to the CHANGELOG? |
The numbers in the file names correspond to the PR number of the repo. To your second questions: yes that's right and yes that would be done as an alternative. |
Yes, but this results in a merge conflict for each change since the PR started. Most importantly, it is so annoying that devs become angry. And angry devs are not got at resolving merge conflicts without accidentally deleting old entries. The steps are easy: |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Some c&p problems I guess. Otherwise good to go from my side.
I am not sure about the markdown lint things.
Do we want to have the changelog-entries
under docs
?
I now have the entries at the base directory |
The failing workflows are not relevant to the addition of the CHANGELOG and hence need to be investigated independently. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I noticed 2-3 small things. Please consider them and then feel free to merge!
@@ -0,0 +1 @@ | |||
- Added new volume coupled diffusion tutorial with FEniCS [#219](https://github.com/precice/tutorials/pull/219) |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Just FYI: this seems to be unrelated. But if this is coming from another branch, then it is fine.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This is indeed a change coming from another PR but as the whole change-log system is implemented here, it has been added via this PR.
Adding a CHANGELOG to the tutorials repository.