-
-
Notifications
You must be signed in to change notification settings - Fork 15
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Update Spack recipe (v2.3.0.1, release documentation, sync packages) #133
Conversation
I changed the GitHub workflow to print the version of the bindings build. It currently prints |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
The Installed version of bindings is 0+unknown
in the test (see https://github.com/precice/python-bindings/runs/3952442029#step:5:122) looks really strange. I will try to debug this. Generally it is useful to get something like Installed version of bindings is v2.3.0.1+5.gd65d39b
here, because this allows us to quickly check that the CI is actually testing the right version. Currently we do not really know.
@@ -26,4 +26,4 @@ jobs: | |||
cp -r spack/repo/packages/py-pyprecice/ /py-pyprecice-repo/packages/ | |||
- name: Try to build py-pyprecice with spack and test it | |||
run: | | |||
. /opt/spack/share/spack/setup-env.sh && spack env activate ci && spack arch && spack find && spack dev-build pyprecice.test.py-pyprecice@develop target=x86_64 && spack load precice py-numpy py-mpi4py py-cython openssh openmpi && mkdir runner && cd runner && python3 -c "import precice; print(precice.__version__)" | |||
. /opt/spack/share/spack/setup-env.sh && spack env activate ci && spack arch && spack find && spack dev-build pyprecice.test.py-pyprecice@develop target=x86_64 && spack load precice py-numpy py-mpi4py py-cython openssh openmpi && export PYTHONPATH=${PWD}/build/$(ls build | grep lib.):${PYTHONPATH} && mkdir runner && cd runner && BINDINGS_VERSION=$(python3 -c "import precice; print(precice.__version__)") && echo "Installed version of bindings is ${BINDINGS_VERSION}" |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
As already discussed personally: Interesting that this has ever worked...
In a local Spack environment (build as in the action) I get |
Same observation on my side, when I use |
Maybe we should just add some |
I just ran the CI locally using
This is also consistent with a local build on my system:
To summarize: I'm really puzzled about the output of the action, if it is run online. I would propose to merge this PR and create an issue on the output of the test. As long as we are not actively checking the output for correctness I would consider this a minor issue. I think we should treat this test with some care. However, it still answers the following questions from my perspective "Does the |
This PR does the following:
Restriction