Develop minimal working version without support for parallel runs and vector-valued functions #15
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Partitioned heat conduction seems to be working now, at least there are no more errors. However, there's still a lot that's commented out because it hasn't been adapted to dolfinx yet. The latest version of dolfinx is required to run the case!
PhilipHildebrand
changed the title
|
Some of the problems with the linter are originating from dead links. This is related to #12 and we should fix this directly on |
BenjaminRodenberg
requested changes
Dec 16, 2022
There was a problem hiding this comment.
I think we are close to done here. @PhilipHildebrand can you take care of the unneeded vertex types? I will then do a final review and merge.
Caused failure of partitioned heat equation tutorial
Actually remove problematic line.
This was referenced Jan 5, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR is for merging the fixed error computation of the partitioned-heat-equation tutorial into develop. Furthermore, any tests of the adapter regarding vector functions have been removed, because vector functions are currently not working.
Important to note is that executing the tests via
python3 setup.py testfails for some reason; executing the tests/ test suites individually does work however.