Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fixes incorrect assertion check from #17 #18

Merged
merged 1 commit into from
Nov 9, 2022
Merged

Fixes incorrect assertion check from #17 #18

merged 1 commit into from
Nov 9, 2022

Conversation

IshaanDesai
Copy link
Member

Description

Fixes #17.

Checklist

  • I made sure that the source files are formatted properly.

@IshaanDesai IshaanDesai requested a review from ajaust October 19, 2022 08:32
Copy link
Collaborator

@ajaust ajaust left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good. Did we not have any tests failing due to this mistake?

@IshaanDesai
Copy link
Member Author

Did we not have any tests failing due to this mistake?

Tests did not compile on my machine, but surprisingly the CI did not complain! Should I look into this or do you think this is expected?

@ajaust
Copy link
Collaborator

ajaust commented Oct 21, 2022

I think the problem is the line

dunecontrol --only=dumux-precice --opts=./dumux-precice/test/cmake-test.opts all

in our CI (both testing CIs). The repository has been renamed to dumux-adapter so this path (and maybe some others in the CI configuration) could be out of date. That the assertion did not create an error in the CI during compilation could be a hint that the test was compiled with DNDEBUG flags. I see this could be the default setting for CMake/DUNE if not (valid?) options file is specified.

@ajaust
Copy link
Collaborator

ajaust commented Oct 21, 2022

But regarding your question. I think it is fine to merge to fix this issue and maybe investigate the broken CI afterwards. I would expect the CI to fail for issues like this wrong assertion.

@IshaanDesai IshaanDesai merged commit 8a5b1cc into develop Nov 9, 2022
@IshaanDesai IshaanDesai deleted the fix-17 branch November 9, 2022 16:25
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Example case ff-pm/flow-over-cube-3d/ does not compile with DuMux v3.6
2 participants