N-API Support #87
Merged
N-API Support #87
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This was referenced Aug 23, 2018
vweevers
reviewed
Aug 23, 2018
vweevers
reviewed
Aug 23, 2018
vweevers
reviewed
Aug 23, 2018
vweevers
reviewed
Aug 23, 2018
| @@ -46,7 +46,7 @@ function urlTemplate (opts) { | |||
| return hostMirrorUrl + '/v{version}/' + packageName | |||
| } | |||
|
|
|||
| if (opts.pkg.binary) { | |||
| if (opts.pkg.binary && opts.pkg.binary.host) { | |||
There was a problem hiding this comment.
Yes. Support for N-API requires a binary property that was not required before. For N-API, the binary property may be missing the host property.
|
I've completed all planned work on this PR. Are there further concerns that need to be addressed before it can be merged? |
ralphtheninja
approved these changes
Sep 27, 2018
|
5.2.0 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This pull request implements changes to
prebuild-installto support installing Node native modules based on N-API by adding a newnapiruntime. The changes are described on the README.This PR should be coordinated with its counterpart PR on
prebuild.