Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Adkernel: updating rtbdemand alias #4063

Merged
merged 45 commits into from
Oct 13, 2022
Merged

Adkernel: updating rtbdemand alias #4063

merged 45 commits into from
Oct 13, 2022

Conversation

ckbo3hrk
Copy link
Contributor

@ckbo3hrk ckbo3hrk commented Oct 6, 2022

🏷 Type of documentation

  • new bid adapter
  • update bid adapter
  • new feature
  • text edit only (wording, typos)
  • bugfix (code examples)
  • new examples

📋 Checklist

@netlify
Copy link

netlify bot commented Oct 6, 2022

Deploy Preview for prebid-docs-preview ready!

Name Link
🔨 Latest commit 2edbbcc
🔍 Latest deploy log https://app.netlify.com/sites/prebid-docs-preview/deploys/6346e05a9322d8000744f511
😎 Deploy Preview https://deploy-preview-4063--prebid-docs-preview.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site settings.

Copy link
Contributor

@bretg bretg left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

There are many other pieces of metadata missing here. Please add deals_supported, fpd_supported, etc. The whole list is at https://docs.prebid.org/dev-docs/bidder-adaptor.html#submitting-your-adapter

It would be nice if you could update the other adkernel docs as well. thanks!

title: RtbDemand.com
description: Prebid RtbDemand.com Bidder Adaptor
pbjs: true
pbs: true
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I don't see a PR for a server-side adapter.

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I guess PR for PBS isn't required for aliased adaptor

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@bretg metadata has been updated for all related aliases

@ckbo3hrk ckbo3hrk requested a review from bretg October 10, 2022 12:23
@bretg
Copy link
Contributor

bretg commented Oct 11, 2022

Thanks - publishers will appreciate all the extra detail. But... PBS does require server-side work. Am trying to get that documentation posted.

In the meantime, none of these aliases support pbs. Please set them all to false unless there's an actual adapter code file or a hard-coded alias.

In other words, if you send a request to PBS with a bidder code of "adbite", the server has no idea that it's linked to the "adkernel" adapter code. Yes, a request from Prebid.js could contain ext.prebid.aliases to define a request-time mapping, but that wouldn't work for AMP or App. In order to claim a given bidder is supported on PBS, there needs to be a hard-coded alias so PBS has reserved that bidder code and links it to the actual coded adapter.

@bretg
Copy link
Contributor

bretg commented Oct 11, 2022

Here's how to create hard-coded aliases:

PBS-Go - see how this is done for verizonmedia which is an alias of yahoossp

  1. Create a yaml file - e.g. static/bidder-info/adbite.yaml
  2. Copy the “core” bidder json schema - e.g. static/bidder-params/adbite.json
  3. Add it to the bidders.go file
  4. Add a few line of code mapping the alias to the adapter in https://github.com/prebid/prebid-server/blob/master/exchange/adapter_builders.go . e.g. openrtb_ext.BidderAdBite: adkernel.Builder

PBS-Java

  1. Just add the aliases to your https://github.com/prebid/prebid-server-java/blob/master/src/main/resources/bidder-config/adkernel.yaml file
adapters:
  adkernel:
    aliases:
      adbite:
        enabled: false
      adomega:
        enabled: false

(Note: the PBS-Go team will someday make hard-coded aliases as easy as PBS-Java.)

@ckbo3hrk
Copy link
Contributor Author

@bretg Thank you for the clarification. I've marked all affected adapters as non-pbs for now. Will do mentioned pbs alias changes as standalone PR.

@bretg bretg merged commit 456cc1e into prebid:master Oct 13, 2022
@ckbo3hrk ckbo3hrk deleted the patch-10 branch October 13, 2022 14:41
ecdrsvc pushed a commit to ecdrsvc/prebid.github.io that referenced this pull request Sep 6, 2023
* Create rtbdemand_com.md

* Delete rtbdemandadk.md

* Update headbidding.md

* Update adsolut.md

* Update audiencemedia.md

* Update waardex_ak.md

* Update adbite.md

* Update houseofpubs.md

* Update bcm.md

* Update engageadx.md

* Update converge.md

* Update adomega.md

* Update denakop.md

* Update rtbanalytica.md

* Update unibots.md

* Update catapultx.md

* Update ergadx.md

* Update turktelekom.md

* Update felixads.md

* Update motionspots.md

* Update displayioads.md

* Update rtbdemand_com.md

* Update sonic_twist.md

* Update rtbdemand_com.md

* Update headbidding.md

* Update adsolut.md

* Update audiencemedia.md

* Update adsolut.md

* Update waardex_ak.md

* Update adbite.md

* Update houseofpubs.md

* Update bcm.md

* Update engageadx.md

* Update converge.md

* Update adomega.md

* Update denakop.md

* Update rtbanalytica.md

* Update unibots.md

* Update catapultx.md

* Update turktelekom.md

* Update felixads.md

* Update motionspots.md

* Update displayioads.md

* Update rtbdemand_com.md

* Update sonic_twist.md
jlaso pushed a commit to AuDigent/prebid.github.io that referenced this pull request Nov 6, 2024
* Create rtbdemand_com.md

* Delete rtbdemandadk.md

* Update headbidding.md

* Update adsolut.md

* Update audiencemedia.md

* Update waardex_ak.md

* Update adbite.md

* Update houseofpubs.md

* Update bcm.md

* Update engageadx.md

* Update converge.md

* Update adomega.md

* Update denakop.md

* Update rtbanalytica.md

* Update unibots.md

* Update catapultx.md

* Update ergadx.md

* Update turktelekom.md

* Update felixads.md

* Update motionspots.md

* Update displayioads.md

* Update rtbdemand_com.md

* Update sonic_twist.md

* Update rtbdemand_com.md

* Update headbidding.md

* Update adsolut.md

* Update audiencemedia.md

* Update adsolut.md

* Update waardex_ak.md

* Update adbite.md

* Update houseofpubs.md

* Update bcm.md

* Update engageadx.md

* Update converge.md

* Update adomega.md

* Update denakop.md

* Update rtbanalytica.md

* Update unibots.md

* Update catapultx.md

* Update turktelekom.md

* Update felixads.md

* Update motionspots.md

* Update displayioads.md

* Update rtbdemand_com.md

* Update sonic_twist.md
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants