-
Notifications
You must be signed in to change notification settings - Fork 1.2k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Adkernel: updating rtbdemand alias #4063
Conversation
✅ Deploy Preview for prebid-docs-preview ready!
To edit notification comments on pull requests, go to your Netlify site settings. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
There are many other pieces of metadata missing here. Please add deals_supported, fpd_supported, etc. The whole list is at https://docs.prebid.org/dev-docs/bidder-adaptor.html#submitting-your-adapter
It would be nice if you could update the other adkernel docs as well. thanks!
dev-docs/bidders/rtbdemand_com.md
Outdated
title: RtbDemand.com | ||
description: Prebid RtbDemand.com Bidder Adaptor | ||
pbjs: true | ||
pbs: true |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I don't see a PR for a server-side adapter.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I guess PR for PBS isn't required for aliased adaptor
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@bretg metadata has been updated for all related aliases
Thanks - publishers will appreciate all the extra detail. But... PBS does require server-side work. Am trying to get that documentation posted. In the meantime, none of these aliases support pbs. Please set them all to false unless there's an actual adapter code file or a hard-coded alias. In other words, if you send a request to PBS with a bidder code of "adbite", the server has no idea that it's linked to the "adkernel" adapter code. Yes, a request from Prebid.js could contain ext.prebid.aliases to define a request-time mapping, but that wouldn't work for AMP or App. In order to claim a given bidder is supported on PBS, there needs to be a hard-coded alias so PBS has reserved that bidder code and links it to the actual coded adapter. |
Here's how to create hard-coded aliases: PBS-Go - see how this is done for verizonmedia which is an alias of yahoossp
PBS-Java
(Note: the PBS-Go team will someday make hard-coded aliases as easy as PBS-Java.) |
@bretg Thank you for the clarification. I've marked all affected adapters as non-pbs for now. Will do mentioned pbs alias changes as standalone PR. |
* Create rtbdemand_com.md * Delete rtbdemandadk.md * Update headbidding.md * Update adsolut.md * Update audiencemedia.md * Update waardex_ak.md * Update adbite.md * Update houseofpubs.md * Update bcm.md * Update engageadx.md * Update converge.md * Update adomega.md * Update denakop.md * Update rtbanalytica.md * Update unibots.md * Update catapultx.md * Update ergadx.md * Update turktelekom.md * Update felixads.md * Update motionspots.md * Update displayioads.md * Update rtbdemand_com.md * Update sonic_twist.md * Update rtbdemand_com.md * Update headbidding.md * Update adsolut.md * Update audiencemedia.md * Update adsolut.md * Update waardex_ak.md * Update adbite.md * Update houseofpubs.md * Update bcm.md * Update engageadx.md * Update converge.md * Update adomega.md * Update denakop.md * Update rtbanalytica.md * Update unibots.md * Update catapultx.md * Update turktelekom.md * Update felixads.md * Update motionspots.md * Update displayioads.md * Update rtbdemand_com.md * Update sonic_twist.md
* Create rtbdemand_com.md * Delete rtbdemandadk.md * Update headbidding.md * Update adsolut.md * Update audiencemedia.md * Update waardex_ak.md * Update adbite.md * Update houseofpubs.md * Update bcm.md * Update engageadx.md * Update converge.md * Update adomega.md * Update denakop.md * Update rtbanalytica.md * Update unibots.md * Update catapultx.md * Update ergadx.md * Update turktelekom.md * Update felixads.md * Update motionspots.md * Update displayioads.md * Update rtbdemand_com.md * Update sonic_twist.md * Update rtbdemand_com.md * Update headbidding.md * Update adsolut.md * Update audiencemedia.md * Update adsolut.md * Update waardex_ak.md * Update adbite.md * Update houseofpubs.md * Update bcm.md * Update engageadx.md * Update converge.md * Update adomega.md * Update denakop.md * Update rtbanalytica.md * Update unibots.md * Update catapultx.md * Update turktelekom.md * Update felixads.md * Update motionspots.md * Update displayioads.md * Update rtbdemand_com.md * Update sonic_twist.md
🏷 Type of documentation
📋 Checklist