New adapter: Flipp #2759
New adapter: Flipp #2759
Conversation
…client side adapter (#5) * OFF-552 fix IMP id being set incorrectly * use impression id as the request id * check startCompact * make bid.h zero * remove unused const --------- Co-authored-by: Hasan Kanjee <[email protected]>
adapters/flipp/flipp.go
Outdated
| const BannerType = "banner" | ||
| const InlineDivName = "inline" | ||
| const FlippBidder = "flipp" | ||
| const DefaultCurrency = "USD" |
There was a problem hiding this comment.
nit:- all these constants can be grouped in one const block for better readability like this :-
const (
BannerType = "banner"
InlineDivName = "inline"
FlippBidder = "flipp"
DefaultCurrency = "USD"
)
adapters/flipp/flipp.go
Outdated
|
|
||
| var Count = int64(1) | ||
| var AdTypes = []int64{4309, 641} | ||
| var DtxTypes = []int64{5061} |
There was a problem hiding this comment.
nit:- These variable declarations can be grouped in a var block for better readability :-
var (
Count = int64(1)
AdTypes = []int64{4309, 641}
DtxTypes = []int64{5061}
)
adapters/flipp/flipp.go
Outdated
|
|
||
| "github.com/buger/jsonparser" | ||
| "github.com/gofrs/uuid" | ||
| "github.com/prebid/openrtb/v17/openrtb2" |
There was a problem hiding this comment.
We have upgraded the version of the openrtb library from v17 to v19. Please update your import statements to use
github.com/prebid/openrtb/v19/openrtb2
adapters/flipp/flipp.go
Outdated
| if responseData.StatusCode == http.StatusNoContent { | ||
| return nil, nil | ||
| } |
There was a problem hiding this comment.
This is correct, but you can also make use of existing util functions :-
if httputil.IsResponseStatusCodeNoContent(responseData) {
return nil, nil
}
adapters/flipp/flipp.go
Outdated
| if responseData.StatusCode == http.StatusBadRequest { | ||
| err := &errortypes.BadInput{ | ||
| Message: "Unexpected status code: 400. Bad request from publisher. Run with request.debug = 1 for more info.", | ||
| } | ||
| return nil, []error{err} | ||
| } | ||
|
|
||
| if responseData.StatusCode != http.StatusOK { | ||
| err := &errortypes.BadServerResponse{ | ||
| Message: fmt.Sprintf("Unexpected status code: %d. Run with request.debug = 1 for more info.", responseData.StatusCode), | ||
| } | ||
| return nil, []error{err} | ||
| } |
There was a problem hiding this comment.
As mentioned above, you can make use of existing util functions for these checks :-
if err := httputil.CheckResponseStatusCodeForErrors(responseData); err != nil {
return nil, []error{err}
}
openrtb_ext/imp_flipp.go
Outdated
| SiteID int64 `json:"siteId"` | ||
| ZoneIds []int64 `json:"zoneIds,omitempty"` | ||
| UserKey string `json:"userKey,omitempty"` | ||
| Options *map[string]interface{} `json:"options,omitempty"` |
There was a problem hiding this comment.
Please add this parameter in json schema defined in static/bidder-params/flipp.json as well
|
@onkarvhanumante @Sonali-More-Xandr thank you for the review. Addressed the comments and confirmed email verification. |
There was a problem hiding this comment.
@hasan-kanjee Thanks for keeping patience with code reviews. Added some suggestions to some json tests and checks
|
@onkarvhanumante thanks again for the review. I made the code formatting changes as you suggested and added some additional test cases. For the UID generation code path, I am unable to mock the |
Good callout/ We can skip |
static/bidder-params/flipp.json
Outdated
| "type": "string" | ||
| }, | ||
| "options": { | ||
| "type": "object" |
There was a problem hiding this comment.
can you please add detailed schema over here? Based on your test jsons here is what it may look like. Please add any other fields that you are expecting as part of this object:-
"options": {
"type": "object",
"properties": {
"startCompact": {
"type": "boolean"
}
}
}
|
Thank you @hasan-kanjee for addressing the comments. I have left one more suggestion on the PR. Please let me know your thoughts on this. Ready to approve it once it's resolved. |
|
@Sonali-More-Xandr @onkarvhanumante added updated options object parameters. Added some additional code so that one of the new parameters is sent to bidding server. |
|
@onkarvhanumante @Sonali-More-Xandr thank you for merging this PR. Can we also merge the documentation PR? |
documentation PR is being reviewed. This PR had a feedback from reviewer prebid/prebid.github.io#4551 (review) |
Co-authored-by: Jairo <[email protected]> Co-authored-by: Mike Lei <[email protected]>
New Flipp Adapter
Link to doc: prebid/prebid.github.io#4551