Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Yeahmobi: Fix Shared Memory Overwriting #1761

Merged
merged 1 commit into from
Mar 25, 2021

Conversation

guscarreon
Copy link
Contributor

Copy of reference field Native needed to be made inside adapters/yeahmobi/yeahmobi.go in order to avoid a data race on shared memory. Authors of source code should be notified and encourage to make any changes to this PR if they disagree with the proposed approach.

@SyntaxNode
Copy link
Contributor

Please contact Yeahmobi using their bidder info email address to inform them of this change.

@guscarreon
Copy link
Contributor Author

@zhaojp,
Recently coded pull request #1756 is meant to enable Prebid Server to find data race conditions in adapter bidder source code. According to this newly coded feature, your adapter might be writing to shared memory and this PR implements an approach to prevent it. Please let us know whether or not you agree with the changes proposed in this pull request or if you rather want to code the fix yourself.

When it comes to adapters' source code improvements, we usually wait a week for owners to come back to us. If we get no feedback, we would go ahead and review and merge this pull request ourselves.

We'd love to hear your take on this issue.

@guscarreon
Copy link
Contributor Author

Seven days passed the original adapter authors didn't come back with any significant feedback in regards of this change. This pull request will be merged and will make this week's release but, if the original source code authors have comments in regards of this changes in the future, they'll be welcome and considered.

@guscarreon guscarreon merged commit ef32c8b into prebid:master Mar 25, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants