-
Notifications
You must be signed in to change notification settings - Fork 774
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Vtrack and event endpoints #1467
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This is awesome! Thank you for tackling such a large feature implementation! My first round of feedback is largely centered around Go specific styling and use of the legacy (read: outdated) account code.
Just to verify, you're coding against this spec?
https://docs.prebid.org/prebid-server/endpoints/pbs-endpoint-event.html
… iss-1015 # Conflicts: # analytics/core.go # config/config.go
Yes, the implementation was based on PBS's Java version. |
Adds /event and /vtrack endpoints
Note: events_enabled column is added to accounts_account table:
SELECT uuid, price_granularity, events_enabled FROM accounts_account where uuid = $1 LIMIT 1
You can add the column to your postgres table by running the following command (adjust accordingly depending on your relational database):
ALTER TABLE account_accounts ADD COLUMN events_enabled BOOLEAN DEFAULT FALSE;
EDIT: Implements #1015