Generate SharedId and send in auction requests #1082
+64
−1
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I based the implementation on this proposal #1057 with a few changes:
.sharedId
property is accessed. This ensures that the latest consents are always checked before usage. However we still want to give app developers control over whether sharedId is used, so I added the flagsharedIdEnabled
that developers need to set before we generate/send SharedIds. Maybe we want to also allow app developers to clear a previously generated id, but I did not implement this.