Support for 1px impression counting methodology #1060
Draft
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
OlenaPostindustria
force-pushed
the
feature/original-api-impression-counting
branch
from
abf5327 to
89fcb59
Compare
OlenaPostindustria
force-pushed
the
feature/original-api-impression-counting
branch
from
f28971f to
0cd4f8f
Compare
OlenaPostindustria
force-pushed
the
feature/original-api-impression-counting
branch
from
4058adf to
0010989
Compare
PrebidMobile/AdUnits/AdUnit.swift
Outdated
| @@ -47,6 +47,8 @@ public class AdUnit: NSObject, DispatcherDelegate { | |||
| /// notification flag set to determine if delegate call needs to be made after timeout delegate is sent | |||
| private var timeOutSignalSent = false | |||
|
|
|||
| private var bannerViewImpressionTracker = BannerViewImpressionTracker() | |||
There was a problem hiding this comment.
We should have a single instance of Impression tracker in AdUnit. All implementation details should be hidden in this object.
PrebidMobile/AdUnits/AdUnit.swift
Outdated
| @@ -163,6 +174,26 @@ public class AdUnit: NSObject, DispatcherDelegate { | |||
| return | |||
| } | |||
|
|
|||
| DispatchQueue.main.async { | |||
There was a problem hiding this comment.
Let's move the logic of starting the viewability tracking out from fetchDemand:
- start viewability tracking on calling of activatePrebidImpressionTracker
- stop tracking on destroying the AdUnit object
- once the tracked view meets the impression tracking criteria - check the content, and if it contains PUC - track the respective impression.
|
Charles session - ImpressionCountingDemo.zip |
|
Charles session with scrollable content - |
OlenaPostindustria
force-pushed
the
feature/original-api-impression-counting
branch
from
9eaa970 to
de8ba8d
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
#790