Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Return error if FetchDemandResult Contains "no internet" #760

Merged
merged 1 commit into from
Jun 10, 2024
Merged

Return error if FetchDemandResult Contains "no internet" #760

merged 1 commit into from
Jun 10, 2024

Conversation

jsligh
Copy link
Collaborator

@jsligh jsligh commented Jun 4, 2024

Fixes #668

@jsligh jsligh requested a review from YuriyVelichkoPI June 4, 2024 14:36
@jsligh jsligh linked an issue Jun 4, 2024 that may be closed by this pull request
Incorrect fetch demand result when internet connection is not available #668
Closed
@jsligh jsligh self-assigned this Jun 4, 2024
YuriyVelichkoPI
YuriyVelichkoPI approved these changes Jun 10, 2024
View reviewed changes
Copy link
Contributor

@YuriyVelichkoPI YuriyVelichkoPI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

I also suggest aligning the iOS behavior for this use case. If the iOS SDK logs a similar misleading message, it is worth fixing.

@jsligh jsligh merged commit f414df5 into master Jun 10, 2024
5 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@YuriyVelichkoPI YuriyVelichkoPI YuriyVelichkoPI approved these changes

Assignees

@jsligh jsligh

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Incorrect fetch demand result when internet connection is not available
2 participants
@jsligh @YuriyVelichkoPI