Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

BannerAdUnit size problem #723

Merged
merged 1 commit into from
Dec 12, 2023
Merged

BannerAdUnit size problem #723

merged 1 commit into from
Dec 12, 2023

Conversation

ValentinPostindustria
Copy link
Collaborator

Closes #722.

@ValentinPostindustria ValentinPostindustria force-pushed the feature/banner_ad_unit_size_problem branch from ad04ab7 to 5e86702 Compare December 8, 2023 18:34
@YuriyVelichkoPI YuriyVelichkoPI marked this pull request as ready for review December 11, 2023 12:46
@YuriyVelichkoPI YuriyVelichkoPI marked this pull request as draft December 11, 2023 12:48
@ValentinPostindustria ValentinPostindustria marked this pull request as ready for review December 12, 2023 12:06
jsligh
jsligh approved these changes Dec 12, 2023
View reviewed changes
Copy link
Collaborator

@jsligh jsligh left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good to me!

@jsligh jsligh merged commit 77abd96 into master Dec 12, 2023
5 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@jsligh jsligh jsligh approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

BannerAdUnit ignores width and height
2 participants
@ValentinPostindustria @jsligh