Delegate size handling when custom renderer is active #713
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
github-maxime-liege
force-pushed
the
custom-rendering-delegate-size-handling
branch
from
70c8a7a to
7b02e30
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Context
When using PluginRenderer, the size are managed by the DisplayView that is an inner view of the BannerView and host the PluginRenderer view. But i don't think this is a good design, it should be the Plugin Renderer that should manage his size.
BannerView
||
===> DisplayView
||
===> PluginRenderer View
Proposal
When PluginRenderer feature is detected and active, it will MATCH_PARENT (current parent: BannerView) constraint in order to respect only the publisher constraint.