Do not include NativeImageAsset exact dimensions in JSON if not specified #703
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
BaloghTamas
reviewed
Oct 20, 2023
PrebidMobile/PrebidMobile-core/src/main/java/org/prebid/mobile/NativeImageAsset.java
Show resolved
Hide resolved
BaloghTamas
approved these changes
Oct 20, 2023
|
@YuriyVelichkoPI @jsligh Should I create an issue ticket for this bug? |
linean
deleted the
bugfix/do-not-include-optional-native-image-assets-parameters-in-json
branch
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Based on OpenRTB Native ads specification width and height for image request are optional so that client can only specify minimum required dimensions.
In the current implementation this is not allowed and width and height are always included in the image request JSON. This bug prevents us from displaying more ads. I would be very grateful for a quick review and including it in the next version.