Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Win event URL #701

Merged
merged 5 commits into from
Oct 12, 2023
Merged

Win event URL #701

merged 5 commits into from
Oct 12, 2023

Conversation

ValentinPostindustria
Copy link
Collaborator

@ValentinPostindustria ValentinPostindustria commented Oct 10, 2023

Move BidInfo creating into static methods to remove duplicated logic.
Closes #699.

@ValentinPostindustria ValentinPostindustria marked this pull request as ready for review October 11, 2023 09:20
@ValentinPostindustria ValentinPostindustria force-pushed the feature/win_event branch 2 times, most recently from 010d24a to 67adf8b Compare October 11, 2023 16:28
Copy link
Contributor

@YuriyVelichkoPI YuriyVelichkoPI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

Copy link
Collaborator

@jsligh jsligh left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good to me!

@jsligh jsligh merged commit 4602764 into master Oct 12, 2023
@jsligh jsligh deleted the feature/win_event branch October 12, 2023 12:01
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Surface win URL via SDK
3 participants