-
Notifications
You must be signed in to change notification settings - Fork 84
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Modify custom targeting after the auction happened #199
Conversation
This allows users to add options after Prebid mutated the Request
… always create a new item anyway
- DemoApp uses `PublisherAdRequest.Builder` - `testPublisherAdRequestBuilder()` test was added
- `testPublisherAdRequestBuilderWithRefresh()` was added
- small tests improvements
@@ -468,6 +472,18 @@ private static void handleDFPCustomTargetingUpdate(HashMap<String, String> bids, | |||
} | |||
} | |||
|
|||
private static void handleAdManagerBuilderCustomTargeting(HashMap<String, String> bids, Object publisherAdRequestBuilder) { | |||
Object publisherAdRequest = Util.callMethodOnObject(publisherAdRequestBuilder, "build"); | |||
removeUsedCustomTargetingForDFP(publisherAdRequest); |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Is this correct?
The builder is able to build multiple PublisherAdRequest
s
This is not removing the custom targeting from the PublisherAdRequest$Builder
, instead this is removing the custom targeting from the publisherAdRequest
from line #476.
The returned publisherAdRequestBuilder
build method will still contain the custom targeting.
Or am I missing something?
Might be worth a test
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@timrijckaert, could you please review testPublisherAdRequest()
test case ?
@anwzhang, could you please review this PR ? |
Description and the main idea #198
As a developer I want to have a possibility to add extra
custom targeting
after bids were retrievedNow publisher can pass an
PublisherAdRequest.Builder