API. No auction response #123
Conversation
PrebidMobile/API1.0/src/test/java/org/prebid/mobile/PrebidServerAdapterTest.java
Outdated
Show resolved
Hide resolved
…tion_response_error # Conflicts: # PrebidMobile/API1.0/src/test/java/org/prebid/mobile/PrebidServerAdapterTest.java
|
@avohraa, could you please approve this PR? |
|
@bszekely1, will you please review this PR. All the changes were approved by @avohraa, I just merged master into this branch. After that I will be unblocked |
| ArgumentCaptor<String> uuidAC = ArgumentCaptor.forClass(String.class); | ||
|
|
||
| verify(mockListener).onDemandFailed(resultCodeAC.capture(), uuidAC.capture()); | ||
| assertThat(resultCodeAC.getValue(), Matchers.either(Matchers.is(ResultCode.INVALID_ACCOUNT_ID)).or(Matchers.is(ResultCode.PREBID_SERVER_ERROR))); |
There was a problem hiding this comment.
What are the cases that enforce us to assert two ResultCode?
- INVALID_ACCOUNT_ID
- PREBID_SERVER_ERROR
This test case is for the INVALID_ACCOUNT_ID, then why should it pass if onDemandFailed is obtained with other ResultCode (PREBID_SERVER_ERROR in this case)
Also, can we mock the response instead? Something like this:
server.enqueue(new MockResponse().setResponseCode(400).setBody("Invalid request format: No stored request found for id: 1001_INVALID_ACCOUNT_ID"));
| ArgumentCaptor<String> uuidAC = ArgumentCaptor.forClass(String.class); | ||
|
|
||
| verify(mockListener).onDemandFailed(resultCodeAC.capture(), uuidAC.capture()); | ||
| assertThat(resultCodeAC.getValue(), Matchers.either(Matchers.is(ResultCode.INVALID_CONFIG_ID)).or(Matchers.is(ResultCode.PREBID_SERVER_ERROR))); |
There was a problem hiding this comment.
Can we make similar changes for INVALID_CONFIG_ID as well?
There was a problem hiding this comment.
@avohraa, I have updated the PR
|
@avohraa, could you please review these changes |
| if (!successfulMockServerStarted) { | ||
| fail("Mock server was not started"); | ||
| } | ||
| server.enqueue(new MockResponse().setResponseCode(400).setBody("Invalid request format: No stored imp found for id: 1001-1_INVALID_CONFIG_ID")); |
There was a problem hiding this comment.
Sorry for reiterating on this, but can we have that response body from the MockPrebidServerResponses?
Something like: MockPrebidServerResponses.invalidConfigIdFromRubicon.
| if (!successfulMockServerStarted) { | ||
| fail("Mock server was not started"); | ||
| } | ||
| server.enqueue(new MockResponse().setResponseCode(400).setBody("Invalid request format: No stored request found for id: 1001_INVALID_ACCOUNT_ID")); |
There was a problem hiding this comment.
For Invalid Account Id as well.
|
@avohraa, done |
GitHub issue #122