-
Notifications
You must be signed in to change notification settings - Fork 2.1k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
LiveIntent UserId module: Add support for magnite id #9828
Conversation
The test errors seem not to be related to changes in this PR. |
Okay so now we legit have two modules that are not the magnite module returning this with 33across doing the same. I think we need to hold this until you or they submit some sort of tie breaking mechanism to the userid module. |
Hi @patmmccann, you are referring to #9633, right? Will check with product next week and get back to you. |
Hello @patmmccann Could you let me know for which of the following scenarios we are implementing the tie break for: The reason i ask this is: For scenario B) Which approach do you like better? Relying on the load sequence(this provides equal opportunity for both 33Across and Liveintent) or allowing for Magnite to define the priority to pick up this cookie when its own module doesnt have it? |
The id PMC recommends an optional
|
Thank you! |
@patmmccann @jdwieland8282 Can you please have a look at this proposal: #9896? |
@patmmccann Can you please have a look at the proposal for distinguishing providers for id types that can be exposed by multiple modules? #9896 |
@3link Can you update https://github.com/prebid/Prebid.js/blob/master/modules/userId/eids.md with magnite eids |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
this seems to go against #9896, as in including the liveintent module can populate magnite
at the top level instead of inside libp
. is there some other integration pending?
@dgirardi This is correct. This PR started the discussion about exposing the same type of identifiers via multiple user id modules. #9896 is meant to be a place where possible solutions are discussed. Once a solution has been found, I will update this PR. It is possible to flag this PR as blocked? Alternatively, I can convert it to a draft so it does not confuse reviewers. |
Type of change
Description of change
This pull request adds eid mapping for the magnite ids that now can be resolved via the LiveIntent UserId module.
Other information