Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

LiveIntent UserId module: Add support for magnite id #9828

Closed
wants to merge 2 commits into from

Conversation

3link
Copy link
Contributor

@3link 3link commented Apr 19, 2023

Type of change

  • Other

Description of change

This pull request adds eid mapping for the magnite ids that now can be resolved via the LiveIntent UserId module.

Other information

@3link
Copy link
Contributor Author

3link commented Apr 19, 2023

The test errors seem not to be related to changes in this PR.

@patmmccann
Copy link
Collaborator

Okay so now we legit have two modules that are not the magnite module returning this with 33across doing the same. I think we need to hold this until you or they submit some sort of tie breaking mechanism to the userid module.

@3link
Copy link
Contributor Author

3link commented Apr 20, 2023

Okay so now we legit have two modules that are not the magnite module returning this with 33across doing the same. I think we need to hold this until you or they submit some sort of tie breaking mechanism to the userid module.

Hi @patmmccann, you are referring to #9633, right? Will check with product next week and get back to you.

@deepthivenkat
Copy link

Hello @patmmccann Could you let me know for which of the following scenarios we are implementing the tie break for:
A) Magnite cookies are present from the magnite module and LiveIntent user id module also has a magnite cookie
B) Magnite cookies are not present in the magnite module but are present in both 33Across module and LiveIntent user id module

The reason i ask this is:
For scenario A) if the path in which the magnite bidder adapter looks for magnite cookies populated from magnite module is different from the user->ext->eids array, then it is cleaner to implement the logic to read magnite cookies from LI only if magnite cookies are not populated by magnite module from magnite's bidder adapter. If the path is same, then i need to understand a little bit more about how to check if the magnite cookies are already present

For scenario B) Which approach do you like better? Relying on the load sequence(this provides equal opportunity for both 33Across and Liveintent) or allowing for Magnite to define the priority to pick up this cookie when its own module doesnt have it?

@jdwieland8282
Copy link
Member

The id PMC recommends an optional ext.provider field to reference the "source of the source"

"user":{
   "ext":{
      "eids":[
         {
            "source":"magnite.com",
            "uids":[
               {
                  "id":"d88c96-5cb6-410d-827d-b019e476",
                  "atype":1,
                  "ext":{
                     "source":"magnite"
                  }
               }
            ]
         },
         {
            "source":"magnite.com",
            "uids":[
               {
                  "id":"d88c96-5cb6-410d-827d-b019e476",
                  "atype":1,
                  "ext":{
                     "source":"magnite"
                  }
               }
            ]
         }

@deepthivenkat
Copy link

Thank you!

@3link
Copy link
Contributor Author

3link commented May 3, 2023

@patmmccann @jdwieland8282 Can you please have a look at this proposal: #9896?

@3link
Copy link
Contributor Author

3link commented May 8, 2023

@patmmccann Can you please have a look at the proposal for distinguishing providers for id types that can be exposed by multiple modules? #9896

SKOCHERI
SKOCHERI previously approved these changes May 9, 2023
@SKOCHERI
Copy link
Contributor

SKOCHERI commented May 9, 2023

@SKOCHERI SKOCHERI dismissed their stale review May 9, 2023 16:00

eids.md needs update

@3link
Copy link
Contributor Author

3link commented May 10, 2023

@SKOCHERI Done in 68aae95.

@SKOCHERI Please note, there is a concern that is blocking this PR. There is a proposal that might unblock it and requires a review: #9896.

Copy link
Collaborator

@dgirardi dgirardi left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

this seems to go against #9896, as in including the liveintent module can populate magnite at the top level instead of inside libp. is there some other integration pending?

@3link
Copy link
Contributor Author

3link commented Jun 1, 2023

this seems to go against #9896, as in including the liveintent module can populate magnite at the top level instead of inside libp. is there some other integration pending?

@dgirardi This is correct. This PR started the discussion about exposing the same type of identifiers via multiple user id modules. #9896 is meant to be a place where possible solutions are discussed. Once a solution has been found, I will update this PR.

It is possible to flag this PR as blocked? Alternatively, I can convert it to a draft so it does not confuse reviewers.

@3link 3link closed this Jun 14, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

7 participants