Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add Sovrn adapter #95

Closed
wants to merge 20 commits into from
Closed

Add Sovrn adapter #95

wants to merge 20 commits into from

Conversation

pwfsd
Copy link

@pwfsd pwfsd commented Nov 4, 2015

Sovrn adapter. Update from earlier pull request to restrict requests to one per tagid, and one creative size per request to match Sovrn's handling. If multiple sizes are specified only the first will be passed.

@pwfsd
Copy link
Author

pwfsd commented Nov 12, 2015

This has been updated with additional bid responses for error cases, and I removed some conditional debug to clean things up. sovrn.js is the only relevant file in this pull request (the rest of the changes are artifacts of me learning Github, sorry!)

@mkendall07
Copy link
Member

Thanks @pwfsd for the PR!

I've taken sovrn.js and adaptermanager.js files and applied them to separate branch to make the merge easier. Here is the new PR: #107

As such will close this PR now. Thanks!

@mkendall07 mkendall07 closed this Nov 13, 2015
vzhukovsky added a commit to aol/Prebid.js that referenced this pull request May 22, 2017
…20.0 to aolgithub-master

* commit '80a37975d00dadcb5b3e995e26b6fe0a0435f873': (42 commits)
  Updated build status indicator.
  Added adapters in aolPartnersIds.json.
  Added changelog entry.
  Prebid 0.22.2 Release
  Renderer test - use httpbin/post endpoint in place of domain alone
  AdKernal - comment out console.warn in test
  WideOrbit - remove test referencing url with redirect
  add karma-es5-shim again via yarn
  Widespace - fix lint error on build and test
  Fix Object.assign support for IE11 & <
  Widespace - use forEach in place of for...of
  Underdogmedia - use forEach in place of for...of
  PlusepointLite - comment out breaking tests
  Prebid 0.22.1 Release
  set babel plugins @6.22.0
  lock down babel packages @6.24.1
  PulsePointLite: comment out breaking adapter test
  Prebid 0.22.0 Release
  Update polyfills to use core-js. (prebid#1142)
  Mantis - comment out breaking test
  ...
github-mickael-leclerc pushed a commit to ebuzzing/Prebid.js that referenced this pull request Sep 6, 2023
github-baptiste-haudegand pushed a commit to ebuzzing/Prebid.js that referenced this pull request May 21, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants