Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Taboola Bid Adapter: dynamic ttl #8747

Merged
merged 10 commits into from
Jul 28, 2022
+28 −3
Merged

Taboola Bid Adapter: dynamic ttl #8747

Show file tree
Hide file tree
Changes from 2 commits
Commits
Show all changes
10 commits
Select commit Hold shift + click to select a range
9406ede
update-ttl-passing
ahmadlob Jul 27, 2022
90b646a
Merge pull request #7 from taboola/update-ttl-passing
ahmadlob Jul 27, 2022
b789b21
Update taboolaBidAdapter_spec.js
ahmadlob Jul 27, 2022
63f2384
add fallback default value in case of null
ahmadlob Jul 27, 2022
184484f
add semicolons
ahmadlob Jul 27, 2022
afb6a1f
.
ahmadlob Jul 27, 2022
639b6ca
.
ahmadlob Jul 27, 2022
8662d7f
.
ahmadlob Jul 27, 2022
afd8db6
..
ahmadlob Jul 27, 2022
4ccae81
...
ahmadlob Jul 27, 2022
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
4 changes: 2 additions & 2 deletions modules/taboolaBidAdapter.js
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -224,7 +224,7 @@ function getBid(requestId, currency, bidResponse) {
}

const {
price: cpm, crid: creativeId, adm: ad, w: width, h: height, adomain: advertiserDomains, meta = {}
price: cpm, crid: creativeId, adm: ad, w: width, h: height, exp: ttl, adomain: advertiserDomains, meta = {}
} = bidResponse;

if (advertiserDomains && advertiserDomains.length > 0) {
Expand All @@ -233,7 +233,7 @@ function getBid(requestId, currency, bidResponse) {

return {
requestId,
ttl: 60,
ttl,
mediaType: BANNER,
cpm,
creativeId,
Expand Down
26 changes: 26 additions & 0 deletions test/spec/modules/taboolaBidAdapter_spec.js
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -311,6 +311,7 @@ describe('Taboola Adapter', function () {
'crid': '278195503434041083381',
'w': 300,
'h': 250,
'exp': 60,
'lurl': 'http://us-trc.taboola.com/sample'
}
],
Expand Down Expand Up @@ -386,6 +387,31 @@ describe('Taboola Adapter', function () {
const res = spec.interpretResponse(serverResponse, request)
expect(res).to.deep.equal(expectedRes)
});

it('should set the correct ttl form the response', function () {
// set exp-ttl to be 125
const [bid] = serverResponse.body.seatbid[0].bid;
serverResponse.body.seatbid[0].bid[0].exp = 125
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

semicolon?

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

fixed - added semicolon

Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

in the lines below as well, our lgtm ends up flagging missing semicolons

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

added also

Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

tyvm, please note the trailing spaces causing the failed linting checks

const expectedRes = [
{
requestId: request.bids[0].bidId,
cpm: bid.price,
creativeId: bid.crid,
ttl: 125,
netRevenue: false,
currency: serverResponse.body.cur,
mediaType: 'banner',
ad: bid.adm,
width: bid.w,
height: bid.h,
meta: {
'advertiserDomains': bid.adomain
},
}
]
const res = spec.interpretResponse(serverResponse, request)
expect(res).to.deep.equal(expectedRes)
});
})

describe('userData', function () {
Expand Down