Revert "Gdpr Enforcement module and sharedId/pubCommonId modules: vendor consent should not be enforced for first-party-id modules (#8448)" #8648
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…dor consent should not be enforced for first-party-id modules (prebid#8448)" This reverts commit 5ece4bb.
9 tasks
patmmccann
approved these changes
Jul 6, 2022
1 task
bwhisp
pushed a commit
to bwhisp/Prebid.js
that referenced
this pull request
Jul 13, 2022
…dor consent should not be enforced for first-party-id modules (prebid#8448)" (prebid#8648) This reverts commit 5ece4bb.
ahmadlob
referenced
this pull request
in taboola/Prebid.js
Jul 27, 2022
…dor consent should not be enforced for first-party-id modules (#8448)" (#8648) This reverts commit 5ece4bb.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This reverts commit 5ece4bb.
Type of change
Description of change
revert #8448 because of #8647; there are 5 different enforcement hooks that should be bypassed for "vendorless" modules, but the original PR addresses only one. The net result is that sharedId is broken for anyone using GDPR enforcement.