Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Sharethrough Bid Adapter: getUserSyncs URL clean up #8638

Conversation

maphe
Copy link
Contributor

@maphe maphe commented Jul 1, 2022

Type of change

  • Bugfix
  • Code style update (formatting, local variables)

Description of change

  1. we've removed an extra query param from the URLs in getUserSyncs as it was redundant with the URL itself
  2. following the clean up done on the adapter for Prebid 7 compatibility, we've done a little bit of clean up/polish (no functional change there)

Contact: [email protected]

@ChrisHuie ChrisHuie self-requested a review July 5, 2022 22:00
@ChrisHuie ChrisHuie self-assigned this Jul 5, 2022
@ChrisHuie ChrisHuie merged commit 7d3d67b into prebid:master Jul 7, 2022
bwhisp pushed a commit to bwhisp/Prebid.js that referenced this pull request Jul 13, 2022
* [PGE-178206841] Clean up getUserSyncs function

* Increment adapter version
ahmadlob referenced this pull request in taboola/Prebid.js Jul 27, 2022
* [PGE-178206841] Clean up getUserSyncs function

* Increment adapter version
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants