Concert Bid Adapter: adding referrer #8564
Conversation
modules/concertBidAdapter.js
Outdated
| site: bidRequest.params.site || bidderRequest.refererInfo.page | ||
| } | ||
| site: bidRequest.params.site || bidderRequest.refererInfo.page, | ||
| ref: bidderRequest.refererInfo.ref || window.document.referrer |
There was a problem hiding this comment.
I'm curious about the fallback (because this choice is common enough that I wonder if it should be built into refererInfo). It would be used when prebid is running inside an isolated iframe, and its value would usually be the location of the parent frame - why is that preferable to null? Not knowing how this is used in the backend it looks like pollution of the data to me. (sometimes ref is the referrer, sometimes not, and you don't know which is which).
There was a problem hiding this comment.
@dgirardi You're right, that wasn't properly thought through; we don't want the iframe's referrer. I see the pull request has been closed because of lack of CI, so I'll open another one with an update to the line above. Thanks for calling that out!
There was a problem hiding this comment.
Oh no, I just realised I inadvertently closed this PR by messing around with master on our fork. 🤦 Sorry!
ChrisHuie
changed the title
|
circleci did not run |
Type of change
Specifically: adding functionality to the existing Concert adapter
Description of change
Adding a
refparameter to the bid calls, using the various "referrer" properties available in Prebid.(The PR also contains linting-related changes to the file as a whole, to do with
;and whitespace.)