Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Digitrust id integration #3739

Closed
wants to merge 3 commits into from
Closed

Digitrust id integration #3739

wants to merge 3 commits into from

Conversation

goosemanjack
Copy link
Contributor

Type of change

Integration of support for DigiTrust Id within the new UserId module for Prebid.

  • [ X] Feature

Description of change

Integration of support for DigiTrust Id within the new UserId module for Prebid.
This module allows the DigiTrust Id to be accessed by compliant bidder-adapters
via the UserId system.

Other information

Full instructions linked to from the associated Markdown page.
More information on DigiTrust, source code, and implementation guide
may be found at:

DigiTrust is now a part of IAB and maintained by IAB Tech Lab.
https://iabtechlab.com/

@stale
Copy link

stale bot commented Apr 25, 2019

This issue has been automatically marked as stale because it has not had recent activity. It will be closed if no further activity occurs. Thank you for your contributions.

@stale stale bot added the stale label Apr 25, 2019
@goosemanjack
Copy link
Contributor Author

Any review status on this?

@stale stale bot removed the stale label Apr 25, 2019
@bretg
Copy link
Collaborator

bretg commented Apr 26, 2019

Were you going to draft the proposed changes to http://prebid.org/dev-docs/modules/userId.html and http://prebid.org/dev-docs/modules/digitrust.html ?

@goosemanjack
Copy link
Contributor Author

I could certainly make changes to those docs. Where would I find them and gain access? You can send in email if needed.

@bretg bretg removed the request for review from idettman April 26, 2019 17:42
@bretg bretg requested a review from jaiminpanchal27 April 29, 2019 16:03
@goosemanjack
Copy link
Contributor Author

I have made the documentation changes to the prescribed repo. There is a pull request for it:
Pull Request 1298 on prebid.github.io

@bretg bretg removed the needs docs label May 7, 2019
@bretg bretg requested a review from idettman May 7, 2019 02:47
@stale
Copy link

stale bot commented May 21, 2019

This issue has been automatically marked as stale because it has not had recent activity. It will be closed if no further activity occurs. Thank you for your contributions.

@stale stale bot added the stale label May 21, 2019
# Conflicts:
#	modules/userId.js
@stale stale bot removed the stale label May 22, 2019
if (pbjs.idsys == null) {
pbjs.idsys = {};
}
pbjs.idsys[digitrustIdModule.name] = digitrustIdModule;
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

for the sub-module registration, can you use attachIdSystem from the UserId Module, for example:

// add import
import {attachIdSystem} from './userId.js';

// add submodule to the userId module before the setConfig for userSync.userIds is set (ideally when the .js file inits)
attachIdSystem(digitrustIdModule);

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Yes, I'm in the process of reworking. I'm going to submit a fresh PR once ready.

Copy link
Contributor

@idettman idettman left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Left comment

@goosemanjack goosemanjack deleted the digitrustIdIntegration branch May 29, 2019 17:42
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants