-
Notifications
You must be signed in to change notification settings - Fork 2.1k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Digitrust id integration #3739
Digitrust id integration #3739
Conversation
This issue has been automatically marked as stale because it has not had recent activity. It will be closed if no further activity occurs. Thank you for your contributions. |
Any review status on this? |
Were you going to draft the proposed changes to http://prebid.org/dev-docs/modules/userId.html and http://prebid.org/dev-docs/modules/digitrust.html ? |
I could certainly make changes to those docs. Where would I find them and gain access? You can send in email if needed. |
I have made the documentation changes to the prescribed repo. There is a pull request for it: |
This issue has been automatically marked as stale because it has not had recent activity. It will be closed if no further activity occurs. Thank you for your contributions. |
# Conflicts: # modules/userId.js
if (pbjs.idsys == null) { | ||
pbjs.idsys = {}; | ||
} | ||
pbjs.idsys[digitrustIdModule.name] = digitrustIdModule; |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
for the sub-module registration, can you use attachIdSystem
from the UserId Module, for example:
// add import
import {attachIdSystem} from './userId.js';
// add submodule to the userId module before the setConfig for userSync.userIds is set (ideally when the .js file inits)
attachIdSystem(digitrustIdModule);
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Yes, I'm in the process of reworking. I'm going to submit a fresh PR once ready.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Left comment
Type of change
Integration of support for DigiTrust Id within the new UserId module for Prebid.
Description of change
Integration of support for DigiTrust Id within the new UserId module for Prebid.
This module allows the DigiTrust Id to be accessed by compliant bidder-adapters
via the UserId system.
contact email of the adapter’s maintainer
[email protected]
[email protected]
[X ] official adapter submission
Other information
Full instructions linked to from the associated Markdown page.
More information on DigiTrust, source code, and implementation guide
may be found at:
DigiTrust is now a part of IAB and maintained by IAB Tech Lab.
https://iabtechlab.com/