-
Notifications
You must be signed in to change notification settings - Fork 2.1k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
PulsePoint Adapter GDPR support #2471
Merged
Merged
Changes from 24 commits
Commits
Show all changes
26 commits
Select commit
Hold shift + click to select a range
2fba6a2
ET-1691: Pulsepoint Analytics adapter for Prebid. (#1)
anand-venkatraman ca17acb
Merge remote-tracking branch 'upstream/master'
anand-venkatraman 5da43c3
Adding bidRequest to bidFactory.createBid method as per https://githu…
anand-venkatraman cf41114
Merge branch 'master' of https://github.com/prebid/Prebid.js
anand-venkatraman 62756a9
ET-1765: Adding support for additional params in PulsePoint adapter (#2)
anand-venkatraman f8fabb7
Merge branch 'master' of https://github.com/prebid/Prebid.js
anand-venkatraman b9af15c
ET-1850: Fixing https://github.com/prebid/Prebid.js/issues/866
anand-venkatraman 6523c25
Merge pull request #3 from pulsepointinc/ET-1850
anand-venkatraman b5eeb7f
Minor fix
anand-venkatraman 0f33ef5
Merge branch 'master' of https://github.com/prebid/Prebid.js
anand-venkatraman b5dbd34
Merge branch 'master' of https://github.com/prebid/Prebid.js
anand-venkatraman d6fcd11
Merge branch 'master' of https://github.com/prebid/Prebid.js
anand-venkatraman fce16ad
Merge branch 'master' of https://github.com/prebid/Prebid.js
anand-venkatraman 9833867
Merge branch 'master' of https://github.com/prebid/Prebid.js
anand-venkatraman 70924c5
Merge branch 'master' of https://github.com/prebid/Prebid.js
anand-venkatraman 41f4aca
Merge branch 'master' of https://github.com/prebid/Prebid.js
anand-venkatraman aae98a7
Adding mandatory parameters to Bid
anand-venkatraman 6d546ed
Merge from upstream
anand-venkatraman a04a18f
Merge branch 'master' of https://github.com/prebid/Prebid.js
anand-venkatraman 467e9e3
Merge branch 'master' of https://github.com/prebid/Prebid.js
anand-venkatraman af1b3db
Merge branch 'master' of https://github.com/prebid/Prebid.js
anand-venkatraman 0661fc7
Pulsepoint Bid Adapter - GDPR support
anand-venkatraman 861eea3
minor update
anand-venkatraman 4588e9d
minor update
anand-venkatraman 9c9d7df
Merge branch 'master' of https://github.com/prebid/Prebid.js into pul…
anand-venkatraman 6435142
Fixing review comment
anand-venkatraman File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
The GDPR consent data does not exist in the
bidRequests
object, but rather in thebidderRequest
object (which is the second argument).In this case, you'll need to modify the buildRequests function call like so:
Then you can pass in the
bidderRequest
value into theapplyGdpr
function (note - this will be a single object, not an array of objects). You'll still access the consent data withbidderRequest.gdprConsent
.There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Updated.