Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Catch uncaught parse error causing test failures #1128

Merged
merged 2 commits into from
Apr 19, 2017
Merged

Catch uncaught parse error causing test failures #1128

merged 2 commits into from
Apr 19, 2017

Conversation

matthewlane
Copy link
Collaborator

Type of change

  • Bugfix

Description of change

Fixes #1117

Other information

@rizhang

protonate
protonate approved these changes Apr 19, 2017
View reviewed changes
Copy link
Collaborator

@protonate protonate left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@protonate protonate merged commit 183591c into master Apr 19, 2017
@matthewlane matthewlane deleted the testfix/sharethrough-parse branch April 19, 2017 22:45
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@mkendall07 mkendall07 mkendall07 approved these changes

@protonate protonate protonate approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Uncaught JSON.parse error causes test failures
3 participants
@matthewlane @mkendall07 @protonate