convert bidders: kobler

prebid · May 20, 2022 · 50f0610 · 50f0610
1 parent 8ba55cd
commit 50f0610
Show file tree

Hide file tree

Showing 5 changed files with 11 additions and 8 deletions.
diff --git a/modules/jixieBidAdapter.js b/modules/jixieBidAdapter.js
@@ -116,10 +116,12 @@ function getMiscDims_() {
     mkeywords: ''
   }
   try {
+    // TODO: this should pick refererInfo from bidderRequest
     let refererInfo_ = getRefererInfo();
-    let url_ = ((refererInfo_ && refererInfo_.referer) ? refererInfo_.referer : window.location.href);
+    // TODO: does the fallback make sense here?
+    let url_ = refererInfo_?.page || window.location.href
     ret.pageurl = url_;
-    ret.domain = parseUrl(url_).host;
+    ret.domain = refererInfo_?.domain || window.location.hostname
     ret.device = getDevice_();
     let keywords = document.getElementsByTagName('meta')['keywords'];
     if (keywords && keywords.content) {

diff --git a/modules/justpremiumBidAdapter.js b/modules/justpremiumBidAdapter.js
@@ -25,7 +25,8 @@ export const spec = {
       }).filter((value, index, self) => {
         return self.indexOf(value) === index
       }),
-      referer: bidderRequest.refererInfo.referer,
+      // TODO: is 'page' the right value here?
+      referer: bidderRequest.refererInfo.page,
       sw: dim.screenWidth,
       sh: dim.screenHeight,
       ww: dim.innerWidth,

diff --git a/modules/kargoBidAdapter.js b/modules/kargoBidAdapter.js
@@ -213,6 +213,7 @@ export const spec = {
   _getAllMetadata(tdid, usp, gdpr) {
     return {
       userIDs: spec._getUserIds(tdid, usp, gdpr),
+      // TODO: this should probably look at refererInfo
       pageURL: window.location.href,
       rawCRB: spec._readCookie('krg_crb'),
       rawCRBLocalStorage: spec._getLocalStorageSafely('krg_crb')

diff --git a/modules/koblerBidAdapter.js b/modules/koblerBidAdapter.js
@@ -94,9 +94,8 @@ export const onTimeout = function (timeoutDataArray) {
 function buildOpenRtbBidRequestPayload(validBidRequests, bidderRequest) {
   const imps = validBidRequests.map(buildOpenRtbImpObject);
   const timeout = bidderRequest.timeout || config.getConfig('bidderTimeout') || DEFAULT_TIMEOUT;
-  const pageUrl = (bidderRequest.refererInfo && bidderRequest.refererInfo.referer)
-    ? bidderRequest.refererInfo.referer
-    : window.location.href;
+  // TODO: does the fallback make sense here?
+  const pageUrl = bidderRequest.refererInfo?.page || window.location.href
 
   const request = {
     id: bidderRequest.auctionId,

diff --git a/test/spec/modules/koblerBidAdapter_spec.js b/test/spec/modules/koblerBidAdapter_spec.js
@@ -10,7 +10,7 @@ function createBidderRequest(auctionId, timeout, pageUrl) {
     auctionId: auctionId || 'c1243d83-0bed-4fdb-8c76-42b456be17d0',
     timeout: timeout || 2000,
     refererInfo: {
-      referer: pageUrl || 'example.com'
+      page: pageUrl || 'example.com'
     }
   };
 }
@@ -301,7 +301,7 @@ describe('KoblerAdapter', function () {
       const bidderRequest = {
         auctionId: 'c1243d83-0bed-4fdb-8c76-42b456be17d0',
         refererInfo: {
-          referer: 'example.com'
+          page: 'example.com'
         }
       };
       config.setConfig({