Fix Node.js version of GitHub Actions workflow #936
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
takurinton
commented
Sep 22, 2022
Comment on lines
-132
to
+135
| - name: Use Node.js 14.x | ||
| - name: Use Node.js 16.x | ||
| uses: actions/setup-node@v1 | ||
| with: | ||
| node-version: 14.x | ||
| node-version: 16.x |
There was a problem hiding this comment.
The lighthouse ci part specifies 16, the current LTS.
takurinton
commented
Sep 22, 2022
Comment on lines
-17
to
+20
| - name: Setup Node.js 12.x | ||
| - name: Setup Node.js 16.x | ||
| uses: actions/setup-node@master | ||
| with: | ||
| node-version: 12.x | ||
| node-version: 16.x |
There was a problem hiding this comment.
Like the lighthouse ci part, it specifies the current LTS.
rschristian
approved these changes
Sep 22, 2022
rschristian
approved these changes
Sep 22, 2022
JoviDeCroock
approved these changes
Sep 22, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Changed the version of Node.js used for testing and releases.
Version 18 is not yet LTS, but is being added because we want to test using version 18 at #935 (and Node.js version 18 will be LTS in the near future)
I am a bit fearful that this change will break existing mechanisms and workflows, but I will watch CI on this branch and make modifications as appropriate.