Simplify Node instances #233
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The flag can be replaced in ._subscribe with an alternative check so that the method stays idempotent, and ._unsubscribe should be idempotent without any additional checks.
Use Node._version === -1 to replace the NODE_FREE flag.
Use an early return for delicious byte savings.
🦋 Changeset detectedLatest commit: 3f652a7 The changes in this PR will be included in the next version bump. This PR includes changesets to release 1 package
Not sure what this means? Click here to learn what changesets are. Click here if you're a maintainer who wants to add another changeset to this PR |
✅ Deploy Preview for preact-signals-demo ready!
To edit notification comments on pull requests, go to your Netlify site settings. |
|
Size Change: -307 B (0%) Total Size: 67.1 kB
ℹ️ View Unchanged
|
JoviDeCroock
approved these changes
Oct 7, 2022
Merged
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This pull request simplifies the Node objects used in the core by removing the
Node._flagsproperty:Signal._subscribeandSignal._unsubscribeidempotent. Turns out that_unsubscribeis idempotent regardless, and_subscribecan use an alternative check.Node._versionproperty for a similar purpose, marking the Nodes for old dependencies by setting their_versionvalue to -1. If a Node does get reused, then its_versionafter recompute/effect will be>= 0, so we can detect reused Nodes that way. I added a note toSignal._versionthat its values should always be>= 0, just to remind us in the future.The end result is that the performance doesn't seem to suffer, Node instances take around 8% less memory (in my environment, using a supremely unscientific method of calculation), and there are some nice byte size savings.