Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix: Missing MemoExoticComponent type in compat #3898

Merged
merged 3 commits into from
Feb 21, 2023
Merged

fix: Missing MemoExoticComponent type in compat #3898

merged 3 commits into from
Feb 21, 2023

Conversation

rschristian
Copy link
Member

Closes #3897

Adapted from React's type

Seems to work well, provided I'm not missing anything.

@coveralls
Copy link

coveralls commented Feb 15, 2023 •
edited
Loading

Coverage Status

Coverage: 99.548%. Remained the same when pulling c68a6b2 on types/compat-memo-exotic-component into 5624b3c on master.

developit
developit approved these changes Feb 17, 2023
View reviewed changes
Copy link
Member

@developit developit left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nice. This is better than faking the type for sure.

@rschristian rschristian merged commit a96e644 into master Feb 21, 2023
@rschristian rschristian deleted the types/compat-memo-exotic-component branch February 21, 2023 17:25
JoviDeCroock added a commit that referenced this pull request Jan 16, 2024
@JoviDeCroock
backport #3898
d4d64d0
JoviDeCroock added a commit that referenced this pull request Jan 16, 2024
@JoviDeCroock
V11 update 10 13 (#4257)
4601cf3 
* backport #3911

* backport #3906

* backport #3837

* backport #3908

* backport #3904

* backport #3905

* backport #3898

* backport #3910

* backport #3948

* backport #3941

* backport #3945

* backport #3919

* backport #3922

* backport #3921

* backport #3903

* fix lint

* update more

* debug
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@developit developit developit approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Types: Missing MemoExoticComponent in preact/compat
3 participants
@rschristian @coveralls @developit