Fix swapped jsx runtime __source and __self arguments
#3459
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
JoviDeCroock
approved these changes
Feb 19, 2022
|
Size Change: 0 B Total Size: 42.2 kB ℹ️ View Unchanged
|
JoviDeCroock
pushed a commit
that referenced
this pull request
Feb 3, 2023
* There was a parameter missing (`isStaticChildren: boolean`), which is not useful\*, but is still being passed * Fix order of `source` and `self` again (incorrectly introduced in GH-3459) * Fix some (internal JSDoc) types for these parameters My guess is that the previous PR “fixed” the earlier problem because `self` isn’t used, so by calling `isStaticChildren` “`self`”, a bug went away. The source for where this `jsxDEV` call is generated in Babel is here: <https://github.com/babel/babel/blob/3952486/packages/babel-plugin-transform-react-jsx/src/create-plugin.ts#L506-L508>. The React RFC for the transform that mentions the dev runtime is here: <https://github.com/reactjs/rfcs/blob/createlement-rfc/text/0000-create-element-changes.md#dev-only-transforms> \* `isStaticChildren` is the same as whether `jsxs` would be used, instead of `jsx`. Which is also whether there are 2 or more children passed: * `<a />` -> `jsx('a', {})` * `<a>b</a>` -> `jsx('a', {children: 'b'})` * `<a>{1}{2}</a>` -> `jsxs('a', {children: [1, 2]})` Related-to: GH-3459.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
While working on preactjs/preset-vite#40 I noticed that our argument order to
jsxDEVdiffers from the argument order babel transpiles to. There the__sourceargument comes last and the__sourceis before that. Basically the other way round than what we have.