JSDoc updates to pass checkJs #1171
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
* Improved JSDoc comments for better type check in VSCode with “implicitProjectConfig.checkJs": true” to enable type checking for JavaScript. * Introduced JSDoc type casting to solve problems with type coercion. * Updated JSDoc comment for VNode. Attribures property was set to type “object”. Unfortunately JSDoc types “object” and “Object” get treated as type “any” by TypeScript. To indicate a generic object you have to use this signature: Object.<string, any>. * Add type cast for Ctor being called with new keyword to avoid warning "Cannot use 'new' with an expression whose type lacks a call or construct signature". * Added type casting where type is a function, but original value could be a string as well. This tells type checker that the value can be called. * Added numerous type casts in diff.js to resolve type conflicts, where type coercion would happen during runtime in browser, but static type checkers can’t foresee. * Type casting adds an extra pair of parens around the value being cast. But these are removed during minification. * Moved JSDoc imports to the beginning of each module. * Other minor updates and fixes Now passes tsc --checkJs Co-authored-by: Robert Biggs <[email protected]> Co-authored-by: Christopher J. Brody <[email protected]>
brodycj
force-pushed
the
check-js-updates
branch
from
982b1b5
to
343da26
Compare
|
Closing, for now at least. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Proposed updates by @rbiggs and @brodybits to pass
tsc --checkJsfrom GH-1161, including new changes proposed by @brodybits in rbiggs/preact#4, squashed and rebased onmasterbranch.